ngircd

Free, portable and lightweight Internet Relay Chat server http://ngircd.barton.de/
Log | Files | Refs | README | LICENSE

commit ffad2da835e26a1a457d4f4a16acf6797d4cc71e
parent 3f1547ecdec24fd685f05e40733ae0d907bcb9d8
Author: Alexander Barton <alex@barton.de>
Date:   Wed, 10 Sep 2014 13:03:30 +0200

Correctly check that a server has a valid hostname and port

David Binderman <dcb314@hotmail.com> reported the following compiler warning,
which is a real bug in ngIRCd, thanks!

conn.c:2077:55: warning: logical not is only applied to the left hand
                         side of comparison [-Wlogical-not-parentheses]

Diffstat:
Msrc/ngircd/conn.c | 2+-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c @@ -1904,7 +1904,7 @@ Check_Servers(void) for (i = 0; i < MAX_SERVERS; i++) { if (Conf_Server[i].conn_id != NONE) continue; /* Already establishing or connected */ - if (!Conf_Server[i].host[0] || !Conf_Server[i].port > 0) + if (!Conf_Server[i].host[0] || Conf_Server[i].port <= 0) continue; /* No host and/or port configured */ if (Conf_Server[i].flags & CONF_SFLAG_DISABLED) continue; /* Disabled configuration entry */