inspircd

A modular C++ IRC daemon (ircd). https://www.inspircd.org/
Log | Files | Refs | README

commit ad92bdb83f148a47c6c166d01fc1870ee05df38f
parent 2aeb1606e5e90d087f0368409dd72709ba01b759
Author: Peter Powell <petpow@saberuk.com>
Date:   Tue, 11 Jun 2019 10:02:35 +0100

Fix echo-message replies being considered a side effect.

Diffstat:
Minclude/modules/ctctags.h | 3---
Msrc/modules/m_ircv3_ctctags.cpp | 3+++
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/modules/ctctags.h b/include/modules/ctctags.h @@ -36,7 +36,6 @@ class CTCTags::TagMessage : public ClientProtocol::Message { PushParamRef(targetchan->name); AddTags(Tags); - SetSideEffect(true); } TagMessage(User* source, const User* targetuser, const ClientProtocol::TagMap& Tags) @@ -47,7 +46,6 @@ class CTCTags::TagMessage : public ClientProtocol::Message else PushParam("*"); AddTags(Tags); - SetSideEffect(true); } TagMessage(User* source, const char* targetstr, const ClientProtocol::TagMap& Tags) @@ -55,7 +53,6 @@ class CTCTags::TagMessage : public ClientProtocol::Message { PushParam(targetstr); AddTags(Tags); - SetSideEffect(true); } }; diff --git a/src/modules/m_ircv3_ctctags.cpp b/src/modules/m_ircv3_ctctags.cpp @@ -76,6 +76,7 @@ class CommandTagMsg : public Command unsigned int minrank = pm ? pm->GetPrefixRank() : 0; CTCTags::TagMessage message(source, chan, parameters.GetTags()); + message.SetSideEffect(true); const Channel::MemberMap& userlist = chan->GetUsers(); for (Channel::MemberMap::const_iterator iter = userlist.begin(); iter != userlist.end(); ++iter) { @@ -117,6 +118,7 @@ class CommandTagMsg : public Command if (InspIRCd::Match(ServerInstance->Config->ServerName, servername)) { CTCTags::TagMessage message(source, "$*", parameters.GetTags()); + message.SetSideEffect(true); const UserManager::LocalList& list = ServerInstance->Users.GetLocalUsers(); for (UserManager::LocalList::const_iterator iter = list.begin(); iter != list.end(); ++iter) { @@ -184,6 +186,7 @@ class CommandTagMsg : public Command { // Send to the target if they have the capability and are a local user. CTCTags::TagMessage message(source, localtarget, parameters.GetTags()); + message.SetSideEffect(true); localtarget->Send(msgevprov, message); }