inspircd

A modular C++ IRC daemon (ircd). https://www.inspircd.org/
Log | Files | Refs | README

commit 05756b842f26c647e527ec186c192c8cf448113f
parent 96cc17f65196391a64c38ffcbfb57b8f54ced4b3
Author: Robby <Robby-@users.noreply.github.com>
Date:   Mon, 20 May 2019 17:57:59 +0200

m_filter: Minor cosmetic changes (#1645).


Diffstat:
Mdocs/conf/helpop.conf.example | 2+-
Msrc/modules/m_filter.cpp | 14++++++++------
2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/docs/conf/helpop.conf.example b/docs/conf/helpop.conf.example @@ -508,7 +508,7 @@ q Block quit messages o Don't match against opers r Don't match against registered users c Strip all formatting codes from the message before matching -* Represents all of the above flags except r +* Represents all of the above flags except r - Does nothing, a non-op for when you do not want to specify any flags diff --git a/src/modules/m_filter.cpp b/src/modules/m_filter.cpp @@ -59,12 +59,12 @@ class FilterResult bool from_config; bool flag_no_opers; - bool flag_no_registered; bool flag_part_message; bool flag_quit_message; bool flag_privmsg; bool flag_notice; bool flag_strip_color; + bool flag_no_registered; FilterResult(dynamic_reference<RegexFactory>& RegexEngine, const std::string& free, const std::string& rea, FilterAction act, unsigned long gt, const std::string& fla, bool cfg) : freeform(free) @@ -81,8 +81,8 @@ class FilterResult char FillFlags(const std::string &fl) { - flag_no_opers = flag_no_registered = flag_part_message = flag_quit_message = flag_privmsg = - flag_notice = flag_strip_color = false; + flag_no_opers = flag_part_message = flag_quit_message = flag_privmsg = + flag_notice = flag_strip_color = flag_no_registered = false; for (std::string::const_iterator n = fl.begin(); n != fl.end(); ++n) { @@ -134,9 +134,11 @@ class FilterResult flags.push_back('p'); if (flag_notice) flags.push_back('n'); - /* Order is important here, 'c' must be the last char in the string as it is unsupported - * on < 2.0.10, and the logic in FillFlags() stops parsing when it ecounters an unknown - * character. + + /* Order is important here, as the logic in FillFlags() stops parsing when it encounters + * an unknown character. So the following characters must be last in the string. + * 'c' is unsupported on < 2.0.10 + * 'r' is unsupported on < 3.2.0 */ if (flag_strip_color) flags.push_back('c');